Skip to content

[Chore] Start CodeRabbit review once Ubuntu tests pass - #1581

Draft
zoomote[bot] wants to merge 1 commit into
mainfrom
chore/coderabbit-after-ubuntu-tests-1t718s4phlzit
Draft

[Chore] Start CodeRabbit review once Ubuntu tests pass#1581
zoomote[bot] wants to merge 1 commit into
mainfrom
chore/coderabbit-after-ubuntu-tests-1t718s4phlzit

Conversation

@zoomote

@zoomote zoomote Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

​Created by Roomote. Follow up by mentioning @roomote, in the web UI, or in Discord.

Related GitHub Issue

Requested by a maintainer in Discord (no tracking issue): CodeRabbit review currently waits for the entire required CI matrix, including the slow Windows test jobs, before it starts.

Description

The review-state reconciliation in label-pr-review-state.yml only activated CodeRabbit after every required check passed. This change keeps the full-CI gate (state labels, Zoo Code / PR review gate status, review-guide messaging) exactly as it is, but computes a separate activation condition in the CI-pending branch: CodeRabbit is activated once all required checks except the Windows test jobs (platform-unit-test (windows-…)) have concluded successfully, provided nothing — including Windows — has failed.

Details reviewers may care about:

  • Windows jobs are identified by a /\(windows-[^)]*\)/ match on the required check context, matching the platform-unit-test (windows-latest) matrix job in code-qa.yml.
  • On early activation the guide comment records the existing coderabbit-review-label:<sha> marker, so when the remaining Windows jobs later go green the already-bound activation is kept instead of being recycled (which would re-trigger CodeRabbit on the same commit). An activation label left over from an older head is still recycled.
  • Fail-closed behavior is preserved: Ubuntu (or any other non-Windows required check) pending/failed, a failed Windows run, or unavailable branch rules all keep CodeRabbit deactivated.

Test Procedure

  • pnpm --dir src exec vitest run services/__tests__/pr-review-state-workflow.test.ts — 111 tests pass, including new coverage for: activation when Ubuntu passed and Windows is still running, no activation while Ubuntu is pending, no activation when Ubuntu failed, no activation when Windows failed, no recycling of an early activation bound to the current head, recycling from an older head, and unchanged all-tests-passed behavior.
  • pnpm --dir src run check-types — clean.
  • Full pnpm test from the repo root — passes (10/10 turbo tasks).
  • Pre-commit hooks (prettier + full lint) pass.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Visual Snapshot (UI changes only): If a user would notice this change at a glance (layout, theme tokens, brand elements, empty/error states), I've added or updated a *.visual.tsx snapshot in webview-ui/. See webview-ui/AGENTS.md → "When a UI change needs a snapshot".
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Documentation Updates

  • No documentation updates are required. (Internal CI/review automation behavior only.)

Additional Notes

The state machine phases, maintainerApprovedAfterAutomatedReview ordering, and gate descriptions are intentionally untouched; only the timing of the coderabbit-review-active label changes.

Get in Touch

Roomote (bot) — reach the requesting maintainer via the linked Discord thread above.

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • coderabbit-review-active

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 627eb9d8-905b-4039-8ad3-c0bf6fc3d90b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Review status

This PR was opened by an automated account. A human maintainer must verify the change intent, provenance, and validation before merging.

Current step: Mark the PR ready. Required CI must pass before CodeRabbit starts.

Review-state labels are managed by this workflow; do not edit them manually.

@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant